nixCraft

Hi all,
I am not really familiar with scripting.
I just wanna ask a help from anyone on how to check a file if it exists.
I have here my script on how i did it.

echo "checking MAKEDEV "
if [ ! `ls /dev/MAKEDEV` ]; then exit -1; fi
if [ ! `ls /etc/makedev.d/` ]; then exit -1; fi
if [ ! `ls /usr/sbin/mksock` ]; then exit -1; fi

This is just a simple, if the file exists then it will continue on next, if it does not exists then it will stop.
but the problem is if I want to find a lots of file, the tendency is I will type all of this file. Take for example i will check all the files on busybox if it exists, that would be a lot of time typing if and then.
My point here is i would like to create loop but i dont know.
Maybe i will just type ony:

/dev/MAKEDEV
/etc/makedev.d
/usr/sbin/mksock

and then it will loop to find this files, so saving so much time typing.
I hope somebody will help.
thanks so much, warren

You can do that as follows:
Btw -1 is not accepted in bash as exit code...

rockdalinux your code seems to correct , but it is only looking for file with -f option for directory you need to add -d option
[code]
files="/dev/MAKEDEV /etc/makedev.d /usr/sbin/mksock"
# $i will hold single file at a time in following loop
for i in $files
do
if [ ! -f $i -o ! -d $i ]; then
exit 1
fi
done
[code]

follow up question....
I have actually posted this for almost a year now.
Have patience to review it again.

thanks for this script.
the script will take the inputs from:
files="/dev/MAKEDEV /etc/makedev.d /usr/sbin/mksock"

To make my script smaller, I need to create a file which lists all the files that I need to find . Then my script will take the inputs from that file instead of typing it all in the script. How can i do that?

Thanks,
warren

Replace line
With following two lines:

It will read all filenames from /tmp/filelist.txt file and store list of files to files variable.

__________________
Vivek | My personal blog
Linux Evangelist
Play hard stay cool